Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade for node.js v14+ compatibility #4

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

sanyampandey-nitor
Copy link

  • Added .npmignore
  • Bumped up the major version
  • Updated node engine restriction to >=10
  • Updated "pg" dependency to ^8.7.1

@onel0p3z
Copy link
Collaborator

onel0p3z commented Feb 9, 2022

@sanyampandey-nitor what version of npm are you using? I just realized something I hadn't seen when I started reviewing these PRs: when I installed and linked locally to test, I see the lock file is updated. I wasn't expecting this so I checked and saw the following

image

I'm using npm@8.3.0

Copy link
Collaborator

@onel0p3z onel0p3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG. Tested locally. No issues were observed.

@sanyampandey-nitor
Copy link
Author

@sanyampandey-nitor what version of npm are you using? I just realized something I hadn't seen when I started reviewing these PRs: when I installed and linked locally to test, I see the lock file is updated. I wasn't expecting this so I checked and saw the following

image

I'm using npm@8.3.0

@onel0p3z AWS Beanstalk platform webpage shows latest supported version as -

Node.js versions (npm versions) - 14.18.3 (6.14.15)
These are the exact versions I have used on my dev environment.

@onel0p3z onel0p3z changed the base branch from master to 2.0.0 February 11, 2022 18:15
@onel0p3z onel0p3z changed the title feat: Node JS 14+ compatibility feat: upgrade for node.js v14+ compatibility Feb 11, 2022
@onel0p3z onel0p3z merged commit 6d64a9b into jasonfutch:2.0.0 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants