Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpmlint reports scripts are packaged under python modules directories #33

Closed
marcindulak opened this issue Dec 7, 2016 · 3 comments
Closed

Comments

@marcindulak
Copy link
Contributor

rpmlint (a tool for checking RPM packaging style) uses shebang to decide whether a python file is a script.

https://github.com/jasonish/py-idstools/tree/1dccb619555097cbbddb60095fd8f7da385c722a/idstools/scripts packages the following files as non-executable scripts under the python modules directory:

idstools/scripts/u2fast.py
idstools/scripts/u2spewfoo.py
idstools/scripts/u2eve.py
idstools/scripts/u2json.py
idstools/scripts/eve2pcap.py
idstools/scripts/rulecat.py
idstools/scripts/gensidmsgmap.py

The recommended handling, as reported by rpmlint is to remove the shebang "#! /usr/bin/env python" from those files, like in the case of idstools/scripts/dumpdynamicrules.py

jasonish added a commit that referenced this issue Dec 14, 2016
These scripts aren't intended to be run directly.

Addresses issue #33.
@jasonish
Copy link
Owner

Thanks, yeah those aren't meant to be executed directly.

@marcindulak
Copy link
Contributor Author

I see another new case:

#! /usr/bin/env python

@jasonish jasonish reopened this Dec 15, 2016
@jasonish
Copy link
Owner

Fixed. See 314a449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants