Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_context function to use mutable iterator in main.rs #7

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

antmanler
Copy link
Contributor

This pull request fixes the get_context function in main.rs to use a mutable iterator. Previously, the function used an immutable iterator, which caused issues when trying to replace certain parts of the prompt string. This change ensures that the function correctly replaces the desired parts of the prompt string and improves the overall functionality of the code.

Copy link
Owner

@jasonjmcghee jasonjmcghee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! Wow. You are 100% correct. Pretty bad. We desperately need tests.

@jasonjmcghee jasonjmcghee merged commit 556e98a into jasonjmcghee:main Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants