Resolve programs used in stub() before modifying PATH #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-support-of-arguments-wiht-whitespaces to master * commit '60758e0d3059c9ba04c8b29e347012b27bcb27e6': Fix mockers handling of arguments with white spaces
added 3 commits
May 14, 2019 09:15
Revert "Merge pull request jasonkarns#1 in BB/bats-mocks from feature/fix-mock-support-of-arguments-wiht-whitespaces to master" This reverts commit f2a1350, reversing changes made to 53733e7.
Flamefire
reviewed
Jun 6, 2019
| mkdir -p "${BATS_MOCK_BINDIR}" | ||
| ln -sf "${BASH_SOURCE[0]%stub.bash}binstub" "${BATS_MOCK_BINDIR}/${program}" | ||
| "$MKDIR" -p "${BATS_MOCK_BINDIR}" | ||
| "$LN" -sf "${BASH_SOURCE[0]%stub.bash}binstub" "${BATS_MOCK_BINDIR}/${program}" | ||
|
|
||
| touch "${BATS_MOCK_TMPDIR}/${program}-stub-plan" |
Flamefire
suggested changes
Jun 11, 2019
| @@ -58,7 +58,12 @@ while IFS= read -r line; do | |||
|
|
|||
| case "$argument" in | |||
| "$pattern" ) ;; | |||
| * ) result=1 ;; | |||
| * ) | |||
There was a problem hiding this comment.
This looks similar to my PR #20. Can you test that and if that suits you remove this from this PR
| @@ -1,6 +1,9 @@ | |||
| BATS_MOCK_TMPDIR="${BATS_TMPDIR}" | |||
| BATS_MOCK_BINDIR="${BATS_MOCK_TMPDIR}/bin" | |||
|
|
|||
| MKDIR=$(which mkdir) | |||
There was a problem hiding this comment.
Possibly prefix commands with BATS_MOCK to avoid name clashes with user variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lnandmkdircan't be stubbed because they are used instub.bashafter modifying PATH. So resolve them while PATH is still intact and use the absolute path thereafter.