Added row mask methods #16
Conversation
Changed DisplayDataAddress as clike enum, added methods to DisplayData.
|
I am positive that these changes are |
| /// Represents the desired values of the device, may not match | ||
| /// the current values if it has not been written recently. | ||
| /// Remember to use `.write_display_buffer()` after changing buffer. | ||
| pub buffer: [u8; ROWS_SIZE], |
There was a problem hiding this comment.
Rather than using custom a type, a plain byte is more flexible. It would make sense to restrict users from using u8 if there where invalid states a buffer could be in, which there are none.
There was a problem hiding this comment.
Also marking buffer as public means that its way more easier for people to get the buffer in the state consumers want.
Any bit state in the buffer is a valid state, so it's no harm in marking buffer as public.
| /// # Ok(()) | ||
| /// # } | ||
| /// ``` | ||
| pub fn update_row_mask(&mut self, row: usize, mask: u8) { |
There was a problem hiding this comment.
This function was written before the buffer was marked public. Should it be removed? Should the buffer remain private?
| for row in self.buffer.iter_mut() { | ||
| *row = DisplayData::COMMON_NONE; | ||
| } | ||
| self.buffer = [0; ROWS_SIZE]; |
There was a problem hiding this comment.
Trust the compiler. No need for iteration.
| )?; | ||
|
|
||
| Ok(()) | ||
| ) | ||
| } |
There was a problem hiding this comment.
Removing the endings of similar functions is just a preference really, but makes no difference.
| @@ -27,6 +30,55 @@ bitflags! { | |||
| } | |||
There was a problem hiding this comment.
I dont think it's a good idea to have bitflags when each flag marks a single bit AND all bits can be used to make any byte.
I think it's rather pointless, but it could stay for backwards compatibility.
| const ROW_14 = 14; | ||
| /// Row 15 | ||
| const ROW_15 = 15; | ||
| use DisplayDataAddress::*; |
There was a problem hiding this comment.
Changing from bitflags into enum as it makes more sense. Addresses should not need bitwise operations.
No description provided.