[TEAMMATES#12399] Instructor editing feedback path of a question: unn…

…ecessary scrollbars (TEAMMATES#12409) * Fix issue of unnecessary scrollbars * Fix snapshot issues --------- Co-authored-by: Jason Qiu <jason_qiu@hotmail.com>
jasonqiu212 · Apr 29, 2023 · 1d21aab · 1d21aab
1 parent a4d335d
commit 1d21aab
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/web/app/components/feedback-path-panel/feedback-path-panel.component.html b/src/web/app/components/feedback-path-panel/feedback-path-panel.component.html
@@ -3,7 +3,7 @@
     <b class="feedback-path-title">Feedback Path</b> (Who is giving feedback about whom?)
   </div>
   <div ngbDropdown #mainMenu="ngbDropdown" class="margin-top-15px w-100" autoClose="outside">
-    <button id="btn-feedback-path" class="btn btn-light white-space-normal mw-100 overflow-scroll d-inline-block" ngbDropdownToggle
+    <button id="btn-feedback-path" class="btn btn-light white-space-normal mw-100  d-inline-block" ngbDropdownToggle
             [disabled]="!model.isEditable || commonFeedbackPaths.size === 1" (click)="resetMenu()">
       <span *ngIf="!model.isUsingOtherFeedbackPath" class="text-wrap">
         {{ model.giverType | giverTypeDescription }} will give feedback on <i class="fas fa-arrow-right"></i> {{ model.recipientType | recipientTypeDescription }}

diff --git a/...app/components/question-edit-form/__snapshots__/question-edit-form.component.spec.ts.snap b/...app/components/question-edit-form/__snapshots__/question-edit-form.component.spec.ts.snap
@@ -256,7 +256,7 @@ exports[`QuestionEditFormComponent should snap with default view 1`] = `
             >
               <button
                 aria-expanded="false"
-                class="dropdown-toggle btn btn-light white-space-normal mw-100 overflow-scroll d-inline-block"
+                class="dropdown-toggle btn btn-light white-space-normal mw-100 d-inline-block"
                 disabled=""
                 id="btn-feedback-path"
                 ngbdropdowntoggle=""

diff --git a/...uctor-session-edit-page/__snapshots__/instructor-session-edit-page.component.spec.ts.snap b/...uctor-session-edit-page/__snapshots__/instructor-session-edit-page.component.spec.ts.snap
@@ -1522,7 +1522,7 @@ exports[`InstructorSessionEditPageComponent should snap with feedback session qu
                     >
                       <button
                         aria-expanded="false"
-                        class="dropdown-toggle btn btn-light white-space-normal mw-100 overflow-scroll d-inline-block"
+                        class="dropdown-toggle btn btn-light white-space-normal mw-100 d-inline-block"
                         id="btn-feedback-path"
                         ngbdropdowntoggle=""
                       >
@@ -2245,7 +2245,7 @@ exports[`InstructorSessionEditPageComponent should snap with feedback session qu
                     >
                       <button
                         aria-expanded="false"
-                        class="dropdown-toggle btn btn-light white-space-normal mw-100 overflow-scroll d-inline-block"
+                        class="dropdown-toggle btn btn-light white-space-normal mw-100 d-inline-block"
                         id="btn-feedback-path"
                         ngbdropdowntoggle=""
                       >
@@ -4123,7 +4123,7 @@ exports[`InstructorSessionEditPageComponent should snap with new question added
                 >
                   <button
                     aria-expanded="false"
-                    class="dropdown-toggle btn btn-light white-space-normal mw-100 overflow-scroll d-inline-block"
+                    class="dropdown-toggle btn btn-light white-space-normal mw-100 d-inline-block"
                     id="btn-feedback-path"
                     ngbdropdowntoggle=""
                   >