Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow userRepository.extraAccessTokenFields() to set the iss (issuer) claim #67

Closed
oliverlockwood opened this issue Nov 30, 2022 · 1 comment · Fixed by #70
Closed

Comments

@oliverlockwood
Copy link
Contributor

At the moment, the implementation of encryptAccessToken() always sets the issuer claim (iss) to undefined - see https://github.com/jasonraimondi/ts-oauth2-server/blob/main/src/grants/abstract/abstract.grant.ts#L121.

I appreciate the link to the RFC documentation saying that use of this claim is OPTIONAL, however if it's optional, then surely consumers of the library should be allowed to set it 😃

If you're happy with this proposal then I will put together a PR to make this change.

@jasonraimondi
Copy link
Owner

This would be great, thank you

oliverlockwood added a commit to oliverlockwood/ts-oauth2-server that referenced this issue Dec 6, 2022
jasonraimondi added a commit that referenced this issue Dec 7, 2022
…ields-to-set-iss-and-aud-claims

#67: allow userRepository.extraAccessTokenFields() to set the 'iss' and 'aud' claims
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants