Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed deck name pulling more than just the header #25

Merged
merged 4 commits into from
Nov 12, 2020
Merged

Fixed deck name pulling more than just the header #25

merged 4 commits into from
Nov 12, 2020

Conversation

a-guy-on-the-internet
Copy link
Contributor

Fix for issue #24

@a-guy-on-the-internet
Copy link
Contributor Author

Tell me if you want me to do anything extra

@jasonwilliams
Copy link
Owner

Thanks @MicahGV
A test would be good, similar to what I did here https://github.com/jasonwilliams/anki/blob/master/src/markdown/parsers/__tests__/cardParser.test.ts

@a-guy-on-the-internet
Copy link
Contributor Author

Sure man

@a-guy-on-the-internet
Copy link
Contributor Author

I ended up adding some additional linter config so when I created new files I wouldn't have to care about swapping it over from my default. Also, I hope it's alright if I only focused on the deckName method for the tests.

@jasonwilliams
Copy link
Owner

jasonwilliams commented Nov 12, 2020 •
edited
Loading

@MicahGV this is fantastic, those tests are awesome.
Thanks!

Also, I hope it's alright if I only focused on the deckName method for the tests.

Yes this is no problem

@jasonwilliams jasonwilliams merged commit 4caea80 into jasonwilliams:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-guy-on-the-internet @jasonwilliams