Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct variable name when throwing an error #69

Merged
merged 3 commits into from
May 4, 2022

Conversation

vandenman
Copy link
Contributor

@vandenman vandenman commented Apr 21, 2022

Fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/1816
Fixes jasp-stats/jasp-issues#1691

for the first issue you now get this expected error:
image

for the second issue you get this expected error:
image

@vandenman
Copy link
Contributor Author

@Kucharssim do you have time to review this?

@Kucharssim Kucharssim self-requested a review May 3, 2022 13:06
@Kucharssim
Copy link
Member

Not sure why the unit tests fail, but if you @vandenman think it's not an issue, it's fine to merge this!

@vandenman
Copy link
Contributor Author

They failed because brew update failed:
image

Let's rerun the tests to be sure.

@vandenman vandenman changed the title Use correct variable name when throwing an error [Do Not Merge] Use correct variable name when throwing an error May 4, 2022
@vandenman
Copy link
Contributor Author

I added [Do Not Merge] because I'm using this PR to debug what goes wrong with installing jags on macOs. Once that is resolved I'll remove it and merge this PR.

@vandenman
Copy link
Contributor Author

I fixed the JAGS installation on macOS but now 4.2.0 fails because:
image
🙃

@vandenman vandenman changed the title [Do Not Merge] Use correct variable name when throwing an error Use correct variable name when throwing an error May 4, 2022
@vandenman vandenman merged commit 7dcce68 into jasp-stats:master May 4, 2022
@vandenman vandenman deleted the fix_missing_model branch May 4, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JAGS throws error in stringr::str_count(model, chars): object 'model' not found
2 participants