Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move remaining methods from jnacontrib.jna.Advapi32 to real Advapi32 #821

Closed
hakanai opened this issue May 31, 2017 · 2 comments
Closed

Move remaining methods from jnacontrib.jna.Advapi32 to real Advapi32 #821

hakanai opened this issue May 31, 2017 · 2 comments

Comments

@hakanai
Copy link
Contributor

hakanai commented May 31, 2017

contrib-ntservice is in a questionable supported status. The artifacts aren't listed in any Maven repositories, so they slide further and further out of date with the real JNA release.

I tried to remove the dependency entirely, and it seems like many of the methods in its private copy of Advapi32 are now in the main Advapi32 in jna-platform.

The rest of them could be cut and pasted across.

Obviously there is the problem of tests, which I don't know how you would do for something which creates a service.
@matthiasblaesing
Copy link
Member

While the methods should indeed be moved, the control-ntservice does work and was recently brought in-line with the changes with jna-platform.

@hakanai
Copy link
Contributor Author

hakanai commented Jun 1, 2017

I don't see those releases on any Maven repositories we currently pull from, but I guess I can't check repositories I'm unaware of.

matthiasblaesing added a commit to matthiasblaesing/jna that referenced this issue Aug 13, 2017
@matthiasblaesing
Move Windows Service functions from ntservice project to core
e829c3b 
The ntservice poject contained additional definitions for windows
service related functionality. Unittests are added in the form of a
sample service implementation, that is installed/uninstalled and
invoked.

com.sun.jna.platform.win32.Advapi32:
- StartServiceCtrlDispatcher
- RegisterServiceCtrlHandler
- RegisterServiceCtrlHandlerEx
- SetServiceStatus
- CreateService
- DeleteService

com.sun.jna.platform.win32.Winsvc:
- Handler
- HandlerEx
- SERVICE_MAIN_FUNCTION
- SERVICE_TABLE_ENTRY
- SERVICE_DESCRIPTION
- SERVICE_STATUS_HANDLE

Closes: java-native-access#821
Closes: java-native-access#258
@matthiasblaesing matthiasblaesing mentioned this issue Aug 13, 2017
Merged
matthiasblaesing added a commit to matthiasblaesing/jna that referenced this issue Aug 17, 2017
@matthiasblaesing
Move Windows Service functions from ntservice project to core
5e8c5b8 
The ntservice poject contained additional definitions for windows
service related functionality. Unittests are added in the form of a
sample service implementation, that is installed/uninstalled and
invoked.

com.sun.jna.platform.win32.Advapi32:
- StartServiceCtrlDispatcher
- RegisterServiceCtrlHandler
- RegisterServiceCtrlHandlerEx
- SetServiceStatus
- CreateService
- DeleteService

com.sun.jna.platform.win32.Winsvc:
- Handler
- HandlerEx
- SERVICE_MAIN_FUNCTION
- SERVICE_TABLE_ENTRY
- SERVICE_DESCRIPTION
- SERVICE_STATUS_HANDLE

Closes: java-native-access#821
Closes: java-native-access#258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hakanai @matthiasblaesing