Generate JPMS compatible artifacts in addtion to the existing artifacts #1237
Conversation
matthiasblaesing
force-pushed
the
module-info
branch
from
2e90c4f
to
841ae46
Compare
|
Prebuild binaries: |
| <exports package="com.sun.jna.win32" /> | ||
| <exports package="com.sun.jna.internal" to="com.sun.jna.platform"/> | ||
| <requires module="java.logging" /> | ||
| <requires module="java.desktop" /> |
There was a problem hiding this comment.
BTW, does jna.jar actually require java.desktop module? Couldn't find which class(es) references it 🤔
There was a problem hiding this comment.
Don't see anything in the main classes but there are a few test classes which load java.awt.* or Swing components.
There was a problem hiding this comment.
com.sun.jna.Native:
import java.awt.Component;
import java.awt.GraphicsEnvironment;
import java.awt.HeadlessException;
import java.awt.Window;Going back 10+ year I would vote to separate that out into its own package, regrettably I don't own a time machine :-)
If I remember correctly I had hoped, that we could get away with requires transitive, but it failed at load time, so the higher require requires was chosen. The primary intent of the artifacts is, that it is possible to use JNA on the module path, not more, not less.
No description provided.