Fix SUCCEEDED and FAILED instead of trying to fix the bug where it's vis... #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,6 +40,7 @@ Bug Fixes | |||
| * [#382](https://github.com/twall/jna/pull/382): Fixed memory allocation in `com.sun.jna.platform.win32.WTypes.LPWSTR` and `LPSTR` constructors - [@junak-michal](https://github.com/junak-michal). | |||
| * Fix publish doc links - [@bhamail](https://github.com/bhamail). | |||
| * [#388](https://github.com/twall/jna/issues/388): Ensure native library always opened with provided flags - [@zolyfarkas](https://github.com/zolyfarkas). | |||
| * Make com.sun.jna.platform.win32.COM.COMUtils.SUCCEEDED and FAILED conform to MSDN specification for said macros. [@lwahonen](https://github.com/lwahonen) | |||
There was a problem hiding this comment.
Make this look like everything else, PR link first, period at the end.
|
Sorry to bring this up late, should have done that the first time, but this definitely needs tests, please, to be merged. |
|
As you make changes, just commit with |
…visible. See MSDN for FAILED and SUCCEEDED definitions Changes
|
Added a test. Surprised that this had been merged originally with one in place, and broken too.. |
|
Yes, I am surprised too. Probably my bad. |
dblock
added a commit
that referenced
this pull request
Mar 16, 2015
Fix SUCCEEDED and FAILED instead of trying to fix the bug where it's vis...
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed the COM fixes into single commit as requested