Skip to content

Initial support for 2.x #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Initial support for 2.x #8

merged 1 commit into from
Jan 19, 2022

Conversation

robzienert
Copy link
Contributor

@robzienert robzienert commented Jan 19, 2022

This PR contains the baseline work to support SDK 2.x and also introduced a couple improvements for customization. All changes include:

  • Updating javaoperatorsdk to 2.0.1, fabric8 to 5.11.2, spring boot to 2.5.6.
  • Changed all configurations to reflect naming conventions aligning on "reconciler" over "controller"
  • Added support for custom HttpClient.Factory implementations on KubernetesClient
  • Made CustomResource class resolution customizable via ResourceClassResolver, with a default implementation using Spring's ResolvableType in NaiveResourceClassResolver.
  • Added a destroyMethod for the Operator bean for clean application teardown.
  • Now calling start as part of the Operator bean creation. Since this is totally new behavior, perhaps it should be gated by configuration?

As for NaiveResourceClassResolver, I'm not super happy with it, but it makes the most basic use case functional. I plan to spend time on a more mature implementation later when I have more time.

Closes #7

@csviri
Copy link
Contributor

csviri commented Jan 19, 2022

Thank you @robzienert . LGTM

Now calling start as part of the Operator bean creation. Since this is totally new behavior, perhaps it should be gated by configuration?

I would say not, this is something that you always want.

@csviri csviri merged commit 10707b6 into operator-framework:main Jan 19, 2022
@csviri
Copy link
Contributor

csviri commented Jan 19, 2022

Will add CI/CD pipelines to get it to maven central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for java-operator-sdk 2.0.0
2 participants