Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

Gradle build failure should show informative message #40

Merged
merged 1 commit into from
Mar 30, 2018

Conversation

abhinayagarwal
Copy link
Contributor

Gradle build fails when one or more packages are not present on linux environment. Instead of throwing some useful information, the following message is shown:

FAILURE: Build failed with an exception.

* Where:
Script '~/Documents/openjdk-jfx/buildSrc/linux.gradle' line: 88

* What went wrong:
A problem occurred evaluating script.
> Cannot invoke method split() on null object

With this fix, when the build fails because of missing packages, a more informative message is shown.

FAILURE: Build failed with an exception.

* Where:
Script '~/Documents/openjdk-jfx/buildSrc/linux.gradle' line: 94

* What went wrong:
A problem occurred evaluating script.
> GTK2 development packages not found. If GTK2 packages are installed, please remove the build directory and try again.

@johanvos
Copy link
Collaborator

+1 from me.
I had this error before as well, and a cryptic message about a NULL object doesn't inform the developer of the cause.

@kevinrushforth
Copy link
Collaborator

Looks good to me, too. Have you signed the OCA yet? I don't see your name on the list of OCA Signatories

@abhinayagarwal
Copy link
Contributor Author

Hi Kevin,

I had signed and mailed the OCA on March 27th.

@kevinrushforth
Copy link
Collaborator

OK, thanks.

@johanvos johanvos merged commit 2ee6a7e into javafxports:develop Mar 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants