JDK-8200446: Update minimum boot JDK to 10 #61
Conversation
|
I see the following from the travis-ci build (and similar from appveyor) build:
And that's why I did the PR here first! |
|
I filed issue #62 to track updating the boot JDK used by the CI builds. That is a prerequisite for merging this PR. |
|
Once issue #62 is resolved and we get a successful CI build, I'll squash the commits into one. |
|
As mentioned in this message on the openjfx-dev list, I would like to hold off on this request for a couple days, say, until Monday to see if there are other comments. |
|
I mis-diagnosed the problem with the CI builds. They are already doing a clean build, so that was never the issue. The root cause of the problem is that this proposed fix bumps the generated class file format to that of JDK 10, and gradle 4.3 does not support the JDK 10 classfile format. This causes 'gradle test' to generate more than 7000 warnings of the form: Running a test build with '--info --stacktrace' generates an 85 Mbyte log file. This causes the Travis CI build to fail (once it exceeds 4 Mbytes it will kill the build). The Appveyor build passes, but truncates the logfile, so that only about the last 3Mbytes are stored. The short answer is that we need to update the version of gradle used by the CI builds. Since we will likely need to update to 4.8 once it is release (so we can build with JDK 11), it might be best to hold off on this PR until then. Or we could do it in two steps -- update to gradle 4.6 now and update to 4.8 when it released (after ensuring it will work with JDK 11) -- but it would be a bit more bookkeeping. I will file a JBS issue for this, but will need to put this on hold for a couple of weeks due to other priorities. |
|
I filed JDK-8201553 to track updating gradle. |
kevinrushforth
changed the title
|
Note that this this will be unblocked after #92 is merged, which fixes JDK-8201553. Once it is, I'll rebase this on top of the develop branch and then we can resume reviewing this. |
kevinrushforth
changed the title
|
#92 has been merged a week ago. Is there any reason for not merging this PR yet? |
|
It should be ready to go in soon. I'll rebase the patch again and send a note to openjfx-dev today as a heads up that this is back on review. |
Summary: 1) JDK 10 is now the minimum; 2) set sourceCompatibility=10 so we can use JDK 10 features
Summary: 1) JDK 10 is now the minimum; 2) set sourceCompatibility=10 so we can use JDK 10 features Reviewed-by: prr, jvos
Summary: 1) JDK 10 is now the minimum; 2) set sourceCompatibility=10 so we can use JDK 10 features Reviewed-by: prr, jvos
* 8200285: TabDragPolicy.REORDER prevents ContextMenu from showing Reviewed-by: kcr, aghaisas * 8196031: FX Robot mouseMove fails on Windows 10 1709 with HiDPI Reviewed-by: kcr, mbilla * 8204956: Cleanup whitespace after fix for JDK-8200285 Reviewed-by: kcr * 8200446: Update minimum boot JDK to 10 (javafxports#61) Summary: 1) JDK 10 is now the minimum; 2) set sourceCompatibility=10 so we can use JDK 10 features Reviewed-by: prr, jvos * Travis-CI: use integrated jdk constants (javafxports#97) Reviewed by: @brcolow @johanvos
* 8200285: TabDragPolicy.REORDER prevents ContextMenu from showing Reviewed-by: kcr, aghaisas * 8196031: FX Robot mouseMove fails on Windows 10 1709 with HiDPI Reviewed-by: kcr, mbilla * 8204956: Cleanup whitespace after fix for JDK-8200285 Reviewed-by: kcr * 8200446: Update minimum boot JDK to 10 (javafxports#61) Summary: 1) JDK 10 is now the minimum; 2) set sourceCompatibility=10 so we can use JDK 10 features Reviewed-by: prr, jvos * Travis-CI: use integrated jdk constants (javafxports#97) Reviewed by: @brcolow @johanvos
Fixes JDK-8200446
I'm doing it here first to make sure that the CI system for this sandbox is already using JDK 10 and thus won't be affected.