Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Min/Max rolls result in only min or max Value #304

Closed
3 of 7 tasks
alkanex-xyz opened this issue Mar 22, 2024 · 1 comment · Fixed by #306
Closed
3 of 7 tasks

🐞 Min/Max rolls result in only min or max Value #304

alkanex-xyz opened this issue Mar 22, 2024 · 1 comment · Fixed by #306

Comments

@alkanex-xyz
Copy link

Check for existing bug reports before submitting.

  • I searched for existing Bug Reports and found no similar reports.

Expected Behavior

On testing Min/Max rolls the resultes should be in the rage of the provided min and max values

Current behaviour

The result of Min/max rolls exclude all values between the provided range and result only in the Min or Max Value.
Min_max

Reproduction

I used this formular: dice: 10d[5, 15]

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version Check

1.5.11

Plugin Version

10.4.6

Confirmation

  • I have disabled all other plugins and the issue still persists.

Possible solution

No response

AustinYQM added a commit to AustinYQM/dice-roller that referenced this issue Apr 2, 2024
@AustinYQM AustinYQM mentioned this issue Apr 2, 2024
10 tasks
@AustinYQM
Copy link
Contributor

I believe I have fixed this in my PR.

image

valentine195 added a commit that referenced this issue Apr 15, 2024
* #304 fix

* Revert arbitary range, add defined range with '-' seperator.

* remove unused import I accidently brought in

* fix: Remove Array prototype pollution

* fix: Fixes lexing of new dice range syntax

---------

Co-authored-by: Jeremy Valentine <38669521+valentine195@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants