Fixing squid:S2333 - Redundant modifiers should not be used.

Author: Faisal Hameed

activejdbc/src/main/java/org/javalite/activejdbc/annotations/BelongsTo.java

@@ -31,6 +31,6 @@
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.TYPE)
 public @interface BelongsTo {
-    public Class<? extends Model> parent();
-    public String foreignKeyName();
+    Class<? extends Model> parent();
+    String foreignKeyName();
 }

activejdbc/src/main/java/org/javalite/activejdbc/annotations/BelongsToParents.java

@@ -11,6 +11,6 @@
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.TYPE)
 public @interface BelongsToParents {
-    public BelongsTo[] value();
+    BelongsTo[] value();
 }
 

activejdbc/src/main/java/org/javalite/activejdbc/annotations/BelongsToPolymorphic.java

@@ -36,13 +36,13 @@
      * List of parent classes.
      * @return list of parent classes.
      */
-    public abstract Class<? extends Model>[] parents();
+    Class<? extends Model>[] parents();
 
     /**
      * List of type labels corresponding to parent classes. This is a value to be stored in the
      * "parent_type" column of the child record. Use this to override default behavior (parent  full class name).
      *
      * @return list of type labels corresponding to parent classes. 
      */
-    public String[] typeLabels() default {}; 
+    String[] typeLabels() default {}; 
 }

activejdbc/src/main/java/org/javalite/activejdbc/annotations/DbName.java

@@ -28,5 +28,5 @@
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.TYPE)
 public @interface DbName {
-    public String value();
+    String value();
 }

activejdbc/src/main/java/org/javalite/activejdbc/annotations/IdGenerator.java

@@ -28,5 +28,5 @@
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.TYPE)
 public @interface IdGenerator {
-    public String value();
+    String value();
 }

activejdbc/src/main/java/org/javalite/activejdbc/annotations/IdName.java

@@ -29,5 +29,5 @@
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.TYPE)
 public @interface IdName {
-    public String value();
+    String value();
 }

activejdbc/src/main/java/org/javalite/activejdbc/annotations/Many2Many.java

@@ -37,22 +37,22 @@
     /**
      * This is a type of a model that is the "other" end of the relationship.
      */
-    public Class<? extends Model> other();
+    Class<? extends Model> other();
 
     /**
      * Name of a table used for joining records from other tables.
      */
-    public String join() ;
+    String join() ;
 
     /**
      * Foreign key name of a source table in the join. A "source" table is a table that backs the model
      * on which this annotation is used.
      */
-    public String sourceFKName();
+    String sourceFKName();
 
     /**
      * Foreign key name of a target table in the join table. A "target" table is a table that backs the "other" model.
      */
-    public String targetFKName();
+    String targetFKName();
 }
 

activejdbc/src/main/java/org/javalite/activejdbc/annotations/Table.java

@@ -29,6 +29,6 @@
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.TYPE)
 public @interface Table {
-    public String value();
+    String value();
 
 }

activejdbc/src/main/java/org/javalite/activejdbc/annotations/VersionColumn.java

@@ -11,5 +11,5 @@
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.TYPE)
 public @interface VersionColumn {
-    public String value();
+    String value();
 }