Merge pull request #508 from DevFactory/release/reduntant-field-initializer-fix-1

Code quality fix - Redundant Field Initializer.

Author: Igor Polevoy

activejdbc/src/main/java/org/javalite/activejdbc/Model.java

@@ -61,13 +61,13 @@ public abstract class Model extends CallbackSupport implements Externalizable {
 
     private Map<String, Object> attributes = new CaseInsensitiveMap<Object>();
     private final Set<String> dirtyAttributeNames = new CaseInsensitiveSet();
-    private boolean frozen = false;
+    private boolean frozen;
     private MetaModel metaModelLocal;
     private ModelRegistry modelRegistryLocal;
     private final Map<Class, Model> cachedParents = new HashMap<Class, Model>();
     private final Map<Class, List<Model>> cachedChildren = new HashMap<Class, List<Model>>();
     private boolean manageTime = true;
-    private boolean compositeKeyPersisted = false;
+    private boolean compositeKeyPersisted;
     private Errors errors = new Errors();
 
     protected Model() {

activejdbc/src/main/java/org/javalite/activejdbc/Paginator.java

@@ -47,7 +47,7 @@ public class Paginator<T extends Model> implements Serializable {
     private int currentPage;
     private final boolean fullQuery;
     private final String countQuery;
-    private boolean suppressCounts = false;
+    private boolean suppressCounts;
     private Long count = 0L;
 
 

activejdbc/src/main/java/org/javalite/activejdbc/validation/NumericValidator.java

@@ -28,9 +28,9 @@
 public class NumericValidator extends ValidatorAdapter {
     private final String attribute;
 
-    private Double min = null;
-    private Double max = null;
-    private boolean allowNull = false, onlyInteger = false, convertNullIfEmpty = false;
+    private Double min;
+    private Double max;
+    private boolean allowNull, onlyInteger, convertNullIfEmpty;
 
 
     public NumericValidator(String attribute) {

javalite-common/src/main/java/org/javalite/common/Base64.java

@@ -733,15 +733,15 @@ private int decode0(byte[] src, int sp, int sl, byte[] dst) {
      */
     private static class EncOutputStream extends FilterOutputStream {
 
-        private int leftover = 0;
+        private int leftover;
         private int b0, b1, b2;
-        private boolean closed = false;
+        private boolean closed;
 
         private final char[] base64;    // byte->base64 mapping
         private final byte[] newline;   // line separator, if needed
         private final int linemax;
         private final boolean doPadding;// whether or not to pad
-        private int linepos = 0;
+        private int linepos;
 
         EncOutputStream(OutputStream os, char[] base64,
                         byte[] newline, int linemax, boolean doPadding) {
@@ -848,13 +848,13 @@ private static class DecInputStream extends InputStream {
         private final InputStream is;
         private final boolean isMIME;
         private final int[] base64;      // base64 -> byte mapping
-        private int bits = 0;            // 24-bit buffer for decoding
+        private int bits;            // 24-bit buffer for decoding
         private int nextin = 18;         // next available "off" in "bits" for input;
         // -> 18, 12, 6, 0
         private int nextout = -8;        // next available "off" in "bits" for output;
         // -> 8, 0, -8 (no byte for output)
-        private boolean eof = false;
-        private boolean closed = false;
+        private boolean eof;
+        private boolean closed;
 
         DecInputStream(InputStream is, int[] base64, boolean isMIME) {
             this.is = is;

javalite-common/src/main/java/org/javalite/common/XmlEntities.java

@@ -245,7 +245,7 @@ static class ArrayEntityMap implements EntityMap {
         // TODO this class is not thread-safe
         protected final int growBy;
 
-        protected int size = 0;
+        protected int size;
 
         protected String[] names;
 

javalite-common/src/main/java/org/javalite/http/Request.java

@@ -35,7 +35,7 @@ public abstract class Request<T extends Request> {
 
     protected final HttpURLConnection connection;
     private boolean connected;
-    protected boolean redirect = false;
+    protected boolean redirect;
     protected final String url;
 
     public Request(String url, int connectTimeout, int readTimeout) {