Fixing - squid:S1165:Exception classes should be immutable.

Author: Faisal Hameed

activejdbc/src/main/java/org/javalite/activejdbc/DBException.java

@@ -26,20 +26,23 @@
  */
 public class DBException extends RuntimeException{
 
-    String message;
+    final String message;
 
     public DBException(Throwable cause) {
         super(cause);
         this.setStackTrace(cause.getStackTrace());
+        this.message = null;
     }
 
     public DBException(String message) {
         super(message);
+        this.message = null;
     }
 
     public DBException(String message, Throwable cause) {
         super(message, cause);
         this.setStackTrace(cause.getStackTrace());
+        this.message = null;
     }
 
 
@@ -67,5 +70,6 @@ public String getMessage() {
 
     public DBException() {
         super();
+        this.message = null;
     }
 }

activejdbc/src/main/java/org/javalite/activejdbc/cache/CacheManager.java

@@ -65,7 +65,7 @@ public final void flush(CacheEvent event){
         for(CacheEventListener listener: listeners){
             try{
                 listener.onFlush(event);
-            }catch(Throwable e){
+            }catch(Exception e){
                 logger.warn("failed to propagate cache event: {} to listener: {}", event, listener, e);
             }
         }

activejdbc/src/main/java/org/javalite/activejdbc/validation/ValidationException.java

@@ -27,8 +27,8 @@
  * @author Igor Polevoy
  */
 public class ValidationException extends DBException {
-    private String message = "";
-    private Model source;
+    private final String message;
+    private final Model source;
 
     public ValidationException(Model m){
         message = m.errors().toString();
@@ -38,6 +38,7 @@ public ValidationException(Model m){
     public ValidationException(String message) {
         super(message);
         this.message = message;
+        this.source = null;
     }
 
     @Override

db-migrator/src/main/java/org/javalite/db_migrator/MigrationManager.java

@@ -78,7 +78,7 @@ public void migrate(Log log, String encoding) {
                 versionStrategy.recordMigration(currentMigration.getVersion(), new Date(start), (start - System.currentTimeMillis()));
                 connection().commit();
             }
-        } catch (Throwable e) {
+        } catch (Exception e) {
             try{connection().rollback();}catch(Exception ex){throw new MigrationException(e);}
             assert currentMigration != null;
             throw new MigrationException("Migration for version " + currentMigration.getVersion() + " failed, rolling back and terminating migration.", e);