Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
#570 Using class instance breaks metadata lookup under a different cl…
…ass loader
  • Loading branch information
Igor Polevoy committed Jan 11, 2017
1 parent 016035e commit 4dd6ca0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
Expand Up @@ -69,7 +69,12 @@ Class<? extends Model> getModelClass(String tableName) {
}

String getTableName(Class<? extends Model> modelClass) {
MetaModel mm = metaModelsByClass.get(modelClass);
MetaModel mm = null;
for (Class<? extends Model> clazz: metaModelsByClass.keySet()){
if(modelClass.getName().equals(clazz.getName())){
mm = metaModelsByClass.get(clazz);

This comment has been minimized.

Copy link
@SergeyKhodussov

SergeyKhodussov Jan 12, 2017

Contributor

I think need a "break" success...
...
mm = metaModelsByClass.get(clazz);
break;
...

This comment has been minimized.

Copy link
@ipolevoy

ipolevoy Jan 12, 2017

Member

makes sense! every millisecond counts:)

This comment has been minimized.

Copy link
@SergeyKhodussov

SergeyKhodussov Jan 12, 2017

Contributor

:)

This method also requires fix (MetaModels.java -> getMetaModel):

    MetaModel getMetaModel(Class<? extends Model> modelClass) {
        MetaModel mm = null;
        for (Class<? extends Model> clazz: metaModelsByClass.keySet()){
            if(modelClass.getName().equals(clazz.getName())){
                mm = metaModelsByClass.get(clazz);
                break;
            }
        }
        return mm;
    }
}
}
return mm == null ? null : mm.getTableName();
}

Expand Down
Expand Up @@ -34,6 +34,7 @@ public void shouldPrintJsonLogValuesAndParams(){
String log = SystemStreamUtil.getSystemErr();
SystemStreamUtil.restoreSystemErr();

System.out.println(log);
//Lets test what was logged.
String[] parts = log.split("LazyList -");
String json = parts[1];
Expand Down

0 comments on commit 4dd6ca0

Please sign in to comment.