Skip to content

Commit 61f22af

Browse files
committed
#374 Refactoring of Db.find()
1 parent 583d170 commit 61f22af

File tree

1 file changed

+3
-5
lines changed
  • activejdbc/src/main/java/org/javalite/activejdbc

1 file changed

+3
-5
lines changed

activejdbc/src/main/java/org/javalite/activejdbc/DB.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -456,14 +456,12 @@ public RowProcessor find(String query, Object... params) {
456456

457457
if(!SELECT_PATTERN.matcher(query).find()) { throw new IllegalArgumentException("query must be 'select' query"); }
458458

459-
PreparedStatement ps;
460-
ResultSet rs;
461459
try {
462-
ps = prepareStreamingStatement(query);
460+
PreparedStatement ps = prepareStreamingStatement(query);
463461
setParameters(ps, params);
464-
rs = ps.executeQuery();
462+
ResultSet rs = ps.executeQuery();
465463
return new RowProcessor(rs, ps);
466-
464+
// ps and rs will be closed by RowProcessor
467465
} catch (SQLException e) { throw new DBException(query, params, e); }
468466
}
469467

0 commit comments

Comments
 (0)