Skip to content

Commit 93a24e3

Browse files
committed
Revert "#393 Simplify OracleDialect generated queries"
This reverts commit bef8143.
1 parent 5790270 commit 93a24e3

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

activejdbc/src/main/java/org/javalite/activejdbc/dialects/OracleDialect.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,15 @@ public class OracleDialect extends DefaultDialect {
5050
*/
5151
@Override
5252
public String formSelect(String tableName, String subQuery, List<String> orderBys, long limit, long offset) {
53+
5354
boolean needLimit = limit != -1L;
5455
boolean needOffset = offset != -1L;
5556

5657
StringBuilder fullQuery = new StringBuilder();
5758
if (needOffset) {
5859
fullQuery.append("SELECT * FROM (SELECT t2.*, ROWNUM AS oracle_row_number FROM (");
5960
} else if (needLimit) { // if needLimit and don't needOffset
60-
fullQuery.append("SELECT * FROM (");
61+
fullQuery.append("SELECT * FROM (SELECT t2.* FROM (");
6162
}
6263
//TODO check if this can be simplified removing the alias t
6364
appendSelect(fullQuery, tableName, (needLimit || needOffset) ? "t" : null, subQuery, orderBys);
@@ -69,7 +70,7 @@ public String formSelect(String tableName, String subQuery, List<String> orderBy
6970
fullQuery.append(" AND ROWNUM <= ").append(limit);
7071
}
7172
} else if (needLimit) {
72-
fullQuery.append(") WHERE ROWNUM <= ").append(limit);
73+
fullQuery.append(") t2) WHERE ROWNUM <= ").append(limit);
7374
}
7475

7576
return fullQuery.toString();

0 commit comments

Comments
 (0)