#193 Adding a non-ActiveWeb annotation on action method causes IllegalArgumentException

Author: Igor Polevoy

activeweb/src/main/java/org/javalite/activeweb/AppController.java

@@ -198,9 +198,11 @@ protected List<HttpMethod> allowedActions(String actionMethodName) {
             if (annotations.length == 0) {
                 return Collections.singletonList(HttpMethod.GET);
             } else {
-                List<HttpMethod> res = new ArrayList<HttpMethod>();
+                List<HttpMethod> res = new ArrayList<>();
                 for (Annotation annotation : annotations) {
-                    res.add(HttpMethod.valueOf(annotation.annotationType().getSimpleName()));
+                    try {
+                        res.add(HttpMethod.valueOf(annotation.annotationType().getSimpleName()));
+                    } catch (IllegalArgumentException ignore) {} // we do not know this annotation
                 }
                 return res;
             }

activeweb/src/test/java/app/controllers/BlahAnnotation.java

@@ -0,0 +1,13 @@
+package app.controllers;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * @author Igor Polevoy on 12/10/15.
+ */
+@Retention(RetentionPolicy.RUNTIME)
+@Target(ElementType.METHOD)
+public @interface BlahAnnotation {}

activeweb/src/test/java/app/controllers/Issue193Controller.java

@@ -0,0 +1,15 @@
+package app.controllers;
+
+import org.javalite.activeweb.AppController;
+import org.javalite.activeweb.annotations.GET;
+
+/**
+ * @author Igor Polevoy on 12/10/15.
+ */
+public class Issue193Controller extends AppController {
+
+    @GET @BlahAnnotation
+    public void index(){
+        respond("ok");
+    }
+}

activeweb/src/test/java/org/javalite/activeweb/Issue193Spec.java

@@ -0,0 +1,22 @@
+package org.javalite.activeweb;
+
+import org.junit.Test;
+
+import javax.servlet.ServletException;
+import java.io.IOException;
+
+/**
+ * @author Igor Polevoy on 12/10/15.
+ */
+public class Issue193Spec extends RequestSpec{
+
+    @Test //https://github.com/javalite/activeweb/issues/244
+    public void shouldSanitizeBadContent() throws IOException, ServletException {
+        request.setServletPath("/issue193");
+        request.setMethod("GET");
+
+        dispatcher.doFilter(request, response, filterChain);
+        String result = response.getContentAsString();
+        a(result).shouldBeEqual("ok");
+    }
+}