Skip to content

Commit c05f230

Browse files
author
Igor Polevoy
authored
Merge pull request #542 from kilink/lazylist-to-maps-raw-type
Get rid of raw type usage in LazyList.toMaps
2 parents 4621ece + 83b0fa2 commit c05f230

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

activejdbc/src/main/java/org/javalite/activejdbc/LazyList.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,9 @@ public <E extends Model> LazyList<E> include(Class<? extends Model>... classes)
182182
*
183183
* @return list of maps, where each map represents a row in the resultset keyed off column names.
184184
*/
185-
public List<Map> toMaps(){
185+
public List<Map<String, Object>> toMaps() {
186186
hydrate();
187-
List<Map> maps = new ArrayList<>(delegate.size());
187+
List<Map<String, Object>> maps = new ArrayList<>(delegate.size());
188188
for (T t : delegate) {
189189
maps.add(t.toMap());
190190
}

activejdbc/src/test/java/org/javalite/activejdbc/IncludesTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ public void shouldBeAbleToIncludeParentOne2Many() {
4949
public void shouldBeAbleToIncludeChildrenOne2Many() {
5050
deleteAndPopulateTables("users", "addresses");
5151
LazyList<User> users = User.findAll().orderBy("id").include(Address.class);
52-
List<Map> maps = users.toMaps();
52+
List<Map<String, Object>> maps = users.toMaps();
5353

54-
Map user = maps.get(0);
54+
Map<String, Object> user = maps.get(0);
5555
a(user.get("first_name")).shouldBeEqual("Marilyn");
5656
List<Map> addresses = (List<Map>)user.get("addresses");
5757
a(addresses.size()).shouldBeEqual(3);
@@ -76,7 +76,7 @@ public void shouldBeAbleToIncludeOtherInManyToMany() {
7676
the(patientList).shouldBeTheSameAs(patientList1);
7777
the(patientList.get(0)).shouldBeTheSameAs(patientList1.get(0));
7878

79-
List<Map> doctorsMaps = doctors.toMaps();
79+
List<Map<String, Object>> doctorsMaps = doctors.toMaps();
8080

8181
List<Map> patients = (List<Map>)doctorsMaps.get(0).get("patients");
8282
a(patients.size()).shouldBeEqual(2);

activejdbc/src/test/java/org/javalite/activejdbc/PolymorphicAssociationsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ public void shouldBeAbleToIncludePolymorphicParent() {
156156

157157
final LazyList<Comment> comments = Comment.findAll().orderBy("id").include(Article.class, Post.class);
158158

159-
final List<Map> commentMaps = comments.toMaps();
159+
final List<Map<String, Object>> commentMaps = comments.toMaps();
160160

161161
final Map post = (Map) commentMaps.get(0).get("post");
162162
the(post.get("id")).shouldBeEqual(1);

activejdbc/src/test/java/org/javalite/activejdbc/ToFromXmlSpec.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ public void shouldGenerateFromList(){
135135
public void shouldConvertClobsToString(){
136136
deleteAndPopulateTable("articles");
137137

138-
List<Map> maps = Article.findAll().toMaps();
138+
List<Map<String, Object>> maps = Article.findAll().toMaps();
139139
a(maps.get(0).get("content")).shouldBeA(String.class);
140140
}
141141

0 commit comments

Comments
 (0)