Merge pull request #300 from DevFactory/release/general-code-quality-fix-1

Multiple code quality fix-1

Author: Igor Polevoy

activeweb-testing/src/main/java/org/javalite/activeweb/RequestBuilder.java

@@ -336,7 +336,7 @@ private void submitRequest(String actionName, HttpMethod method) {
         checkParamAndMultipart();
 
         //TODO: refactor this method, getting out of control        
-        if(contentType != null && contentType.equals(MULTIPART) && formItems.size() > 0){
+        if(contentType != null && contentType.equals(MULTIPART) && !formItems.isEmpty()){
             request = new MockMultipartHttpServletRequestImpl();
             for (FormItem item : formItems) {
                 ((AWMockMultipartHttpServletRequest) request).addFormItem(item);

activeweb/src/main/java/org/javalite/activeweb/RequestDispatcher.java

@@ -230,7 +230,7 @@ public void doFilter(ServletRequest req, ServletResponse resp, FilterChain chain
         }finally {
            Context.clear();
             List<String> connectionsRemaining = DB.getCurrrentConnectionNames();
-            if(connectionsRemaining.size() != 0){
+            if(!connectionsRemaining.isEmpty()){
                 logger.warn("CONNECTION LEAK DETECTED ... and AVERTED!!! You left connections opened:"
                         + connectionsRemaining + ". ActiveWeb is closing all active connections for you...");
                 DB.closeAllConnections();

activeweb/src/main/java/org/javalite/activeweb/RouteBuilder.java

@@ -237,7 +237,7 @@ protected boolean matches(String requestUri, HttpMethod httpMethod) throws Class
             String[] tailArr = Arrays.copyOfRange(requestUriSegments, segments.size() - 1, requestUriSegments.length);
             wildCardValue = Util.join(tailArr, "/");
             match = true;
-        }else if(segments.size() == 0 && requestUri.equals("/")){
+        }else if(segments.isEmpty() && requestUri.equals("/")){
             //this is matching root path: "/"
             actionName = "index";
             match = true;
@@ -272,7 +272,7 @@ private boolean wildSegmentsMatch(String[] requestUriSegments) throws ClassLoadE
     }
 
     private boolean methodMatches(HttpMethod httpMethod) {
-        return methods.size() == 0 && httpMethod.equals(HttpMethod.GET) || methods.contains(httpMethod);
+        return methods.isEmpty() && httpMethod.equals(HttpMethod.GET) || methods.contains(httpMethod);
     }
 
     private AppController reloadController() throws ClassLoadException {

activeweb/src/main/java/org/javalite/activeweb/Router.java

@@ -384,7 +384,7 @@ protected String findPackagePrefix(String uri) {
                 resultIndex = i;
             }
         }
-        return candidates.size() > 0 ? candidates.get(resultIndex) : null;
+        return !candidates.isEmpty() ? candidates.get(resultIndex) : null;
     }
 
     //todo: write a regexp one day

javalite-async/src/main/java/org/javalite/async/Async.java

@@ -175,8 +175,8 @@ In my case, below configuration (made on JBoss 7.1.1.Final) has helped:
     private void configurePaging() {
         AddressSettings addressSettings = new AddressSettings();
         addressSettings.setAddressFullMessagePolicy(AddressFullMessagePolicy.PAGE);
-        addressSettings.setMaxSizeBytes(30 * 1024 * 1024);
-        addressSettings.setPageSizeBytes(10 * 1024 * 1024);
+        addressSettings.setMaxSizeBytes(30 * 1024 * 1024L);
+        addressSettings.setPageSizeBytes(10 * 1024 * 1024L);
         addressSettings.setPageCacheMaxSize(20);
         config.getAddressesSettings().put("jms.queue.*", addressSettings);
     }