Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeSessionsWithChangedId() removes sessions instead of updating SESSION_MAP_BY_ID #933

Closed
lmalmeida opened this issue Jul 21, 2020 · 1 comment
Closed

removeSessionsWithChangedId() removes sessions instead of updating SESSION_MAP_BY_ID #933

lmalmeida opened this issue Jul 21, 2020 · 1 comment

Comments

@lmalmeida
Copy link
Contributor

Question,
The SessionListener.removeSessionsWithChangedId clears entries from the SESSION_MAP_BY_ID, when invoked. This has a side effect that all sessions with changed IDs are removed from the list, meaning the number of sessions reported by javamelody is different from the actual number of sessions.
Any particular reason for the current logic (Removal all invalid) instead of updating the SESSION_MAP_BY_ID with the correct id's
@evernat
Copy link
Member

evernat commented Dec 5, 2021

No particular reason. #934 merged.
Thank you.

@evernat evernat closed this as completed Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evernat @lmalmeida