Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple versions of #134

Merged
merged 1 commit into from
Jan 30, 2019

Commits on Jan 26, 2019

  1. fix(ngRequired): set error correctly when inside ngRepeat and false b…

    …y default
    
    Previously, in the required validator, we would read the required setting directly
    from attr.required, where it is set by ngRequired.
    
    However, when the control is inside ngRepeat, ngRequired sets it only after a another digest has
    passed, which means the initial validation run of ngModel does not include the correct required
    setting. (Before commit 0637a21 this would not have been a problem,
    as every observed value change triggered a validation).
    
    We now use the initially parsed value from ngRequired in the validator.
    
    Fixes #16814
    Closes #16820
    Narretz authored Jan 26, 2019
    Configuration menu
    Copy the full SHA
    005dd97 View commit details
    Browse the repository at this point in the history