Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-js/09-classes/03-static-properties-methods/ #134

Merged
merged 13 commits into from May 9, 2019

Conversation

rin-st
Copy link
Contributor

@rin-st rin-st commented May 3, 2019

No description provided.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label May 3, 2019
@CLAassistant
Copy link

CLAassistant commented May 3, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предложения для улучшения перевода.

1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 4, 2019
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

lex111 and others added 9 commits May 5, 2019 17:42
Co-Authored-By: rin-st <rinatkins@gmail.com>
Co-Authored-By: rin-st <rinatkins@gmail.com>
Co-Authored-By: rin-st <rinatkins@gmail.com>
Co-Authored-By: rin-st <rinatkins@gmail.com>
Co-Authored-By: rin-st <rinatkins@gmail.com>
Co-Authored-By: rin-st <rinatkins@gmail.com>
Co-Authored-By: rin-st <rinatkins@gmail.com>
Co-Authored-By: rin-st <rinatkins@gmail.com>
Co-Authored-By: rin-st <rinatkins@gmail.com>
@rin-st
Copy link
Contributor Author

rin-st commented May 5, 2019

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 5, 2019
@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels May 7, 2019
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
1-js/09-classes/03-static-properties-methods/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label May 9, 2019
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@rin-st
Copy link
Contributor Author

rin-st commented May 9, 2019

/done

@javascript-translate-bot javascript-translate-bot removed the changes requested Waiting for changes and /done from PR author label May 9, 2019
@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label May 9, 2019
Copy link
Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mini-fix =)


Как это работает? Снова с использованием прототипов. Как вы уже могли предположить, наследование также даёт классу `Rabbit` ссылку на `Animal` через `[[Prototype]]`.
Как это работает? Снова с использованием прототипов. Как вы уже могли предположить,`extends` даёт Rabbit ссылку `[[Prototype]]` на Animal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

пробел перед extends

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

упс :)

@javascript-translate-bot javascript-translate-bot removed the review needed Review needed, please approve or request changes label May 9, 2019
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label May 9, 2019
@rin-st
Copy link
Contributor Author

rin-st commented May 9, 2019

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 9, 2019
@iliakan
Copy link
Member

iliakan commented May 9, 2019

👍

@iliakan iliakan merged commit fcdf417 into javascript-tutorial:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs +1 One more review needed review needed Review needed, please approve or request changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants