Use realpath #7
Merged
Use realpath #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the vcs status will be updated if the paths get changed, and this causes a lot of unnecessary work
JavascriptIsMagic
added a commit
that referenced
this pull request
Sep 23, 2015
Use realpath for symlink resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a lot of projects under symlinks, and using this package will cause the folder entry to be duplicated in the list of root folders, one for the symlinked path and one for the realpath. This change will cause the realpath to replace the symlinked path. The other option would be to try to preserve the symlinked path, but that is harder to implement.
I also added a quick change to only update the list of roots if it actually changes, since the vcs status gets refreshed every time a new file is opened if the list of roots changes.
And, I tweaked the case of the cakefile (to "Cakefile") since cake complains on linux if the casing isn't correct.
Let me know if I should use the ruby style of function invokation instead.