fix: node_modules packages were being recognized as local

.github/workflows/build.yml

@@ -4,7 +4,7 @@ on:
     branches:
       - master
       - release
-      - release-v2.0.0-beta.2
+      - pre-release
   pull_request:
 jobs:
   test:

CHANGELOG.md

@@ -11,10 +11,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Removed
 ### BREAKING CHANGES
 
+## [2.0.0-beta.3] - 2021-01-26
+
+### Fixed
+- fix: node_modules packages were being recognized as local
+
 ## [2.0.0-beta.2] - 2021-01-26
 
 ### Fixed
-- feat: Add folder resolver-legacy-alias to npm package
+- fix: Add folder resolver-legacy-alias to npm package
 
 ## [2.0.0-beta.1] - 2021-01-26
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-boundaries",
-  "version": "2.0.0-beta.2",
+  "version": "2.0.0-beta.3",
   "description": "Eslint plugin checking architecture boundaries between elements",
   "keywords": [
     "eslint",

sonar-project.properties

@@ -1,6 +1,6 @@
 sonar.organization=javierbrea
 sonar.projectKey=eslint-plugin-boundaries
-sonar.projectVersion=2.0.0-beta.2
+sonar.projectVersion=2.0.0-beta.3
 
 sonar.javascript.file.suffixes=.js
 sonar.sourceEncoding=UTF-8

src/core/elementsInfo.js

@@ -34,7 +34,10 @@ function isScoped(name) {
 
 const externalModuleRegExp = /^\w/;
 function isExternal(name, path) {
-  return !path && (externalModuleRegExp.test(name) || isScoped(name));
+  return (
+    (!path || (!!path && path.indexOf("node_modules") === 0)) &&
+    (externalModuleRegExp.test(name) || isScoped(name))
+  );
 }
 
 function elementCaptureValues(capture, captureSettings) {
@@ -145,15 +148,16 @@ function importInfo(source, context) {
   const path = projectPath(resolve(source, context));
   const isBuiltInModule = isBuiltIn(source, path);
   const isExternalModule = isExternal(source, path);
+  const pathToUse = isExternalModule ? null : path;
   return {
     source,
-    path,
-    isIgnored: isIgnored(path, context.settings),
-    isLocal: !!path && !isBuiltInModule && !isExternalModule,
+    path: pathToUse,
+    isIgnored: !isExternalModule && isIgnored(pathToUse, context.settings),
+    isLocal: !isExternalModule && !isBuiltInModule,
     isBuiltIn: isBuiltInModule,
     isExternal: isExternalModule,
-    baseModule: baseModule(source, path),
-    ...elementTypeAndParents(path, context.settings),
+    baseModule: baseModule(source, pathToUse),
+    ...elementTypeAndParents(pathToUse, context.settings),
   };
 }
 

test/rules/docs-examples/no-unknown.spec.js

@@ -22,6 +22,11 @@ ruleTester.run(RULE, rule, {
       filename: absoluteFilePath("index.js"),
       code: "import foo from './foo'",
     },
+    // External dependencies can be imported
+    {
+      filename: absoluteFilePath("components/atoms/atom-a/AtomA.js"),
+      code: "import 'chalk'",
+    },
   ],
   invalid: [
     // Helpers can't import `foo.js` file because it is unknown

test/rules/one-level/no-unknown.spec.js

@@ -37,6 +37,11 @@ const test = (settings) => {
         filename: absoluteFilePath("components/component-a/ComponentA.js"),
         code: "import ComponentB from 'components/component-b'",
       },
+      // External dependencies can be imported
+      {
+        filename: absoluteFilePath("components/component-a/ComponentA.js"),
+        code: "import 'chalk'",
+      },
     ],
     invalid: [
       // Not recognized type

test/rules/two-levels/external.spec.js

@@ -77,6 +77,11 @@ const test = (settings, options, { absoluteFilePath }) => {
         code: "import React from 'react'",
         options,
       },
+      // External dependencies can be imported
+      {
+        filename: absoluteFilePath("modules/pages/page-a/PageA.js"),
+        code: "import 'chalk'",
+      },
     ],
     invalid: [
       // Helpers can't import react