-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search on regexp characters broken by v2.3.0 #699
Comments
I think it is probably a bug in |
Thank you. I solved it by commenting out line 744 of 2.3.0. 744 s = s.replace(/[-[]{}()+?.,^$|#]/g, '$&'); // Escape regular expression characters |
I am expecting great things of you! |
I suggest renaming this issue to something specific, like "Search on regexp characters broken by v2.3.0" |
I Fixed the title. |
Hello, when can we expect a fixture for this? I'm also having issue with |
Thank you. I hope this gets fixed soon. |
I merged the fix in https://www.npmjs.com/package/list.js-fixed to be able to use it in SQLPage |
Chiming in to hope this gets fixed. Even all the "fixes" don't seem to solve this issue. We're using it to sort books, and among which you can search and sort for ISBN numbers, which typically look something like |
What do you mean ? list.js-fixed works with strings that contain dashes. You can have a look at Example 4 on this page. |
Taken from: javve/list.js#699 Since regex searching isnt used any longer, this escaping isn’t necessary, but it hasn’t been fixed upstream. Fixes #8435 I believe that the searching is fuzzy, so the `-` doesn’t really provide very functional search filtering. (though other examples like ? are more functional)
This is a follow up on a2e298e which patches list.min.js to fix #8435. The fix suggested in javve/list.js#699 only remove the regex handling. Our initial patch was also removing the lowercase processing which broke search. This fixes #10720
This is a follow up on a2e298e which patches list.min.js to fix #8435. The fix suggested in javve/list.js#699 only remove the regex handling. Our initial patch was also removing the lowercase processing which broke search. This fixes #10720
I found a problem caused by a different version.
I can't search the symbols
#
,.
and-
when using a var 2.3.0.For example, here is the code.
https://jsfiddle.net/qrhd438e/
In case of I use var 1.5.0 result shows 'Mark #Twain',
But var 2.3.0 shows nothing.
The text was updated successfully, but these errors were encountered: