Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounced keyup handler in search #683

Conversation

sheffieldnikki
Copy link
Contributor

@sheffieldnikki sheffieldnikki commented Apr 2, 2020

As discussed in #621 this adds an optional debounced event handler in search & fuzzySearch. Setting the new options.searchDelay (default 0 ms) makes searching far more usable with very large lists and/or slow mobile devices.

Added documentation to List API describing the new option, suggesting setting it from 250-750 ms.

clbn and others added 30 commits November 17, 2017 16:02
Changed license date
Now LICENSE is up to date.
LICENSE and README.md files are not up to date
Fix typos in error message
@codecov-io
Copy link

codecov-io commented Apr 2, 2020

Codecov Report

Merging #683 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #683   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files          19       19           
  Lines         818      818           
  Branches      195      195           
=======================================
  Hits          768      768           
  Misses         34       34           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071b1a7...071b1a7. Read the comment docs.

@SanmayJoshi
Copy link

Hi @sheffieldnick , I have forked this library and started a new project under the name of invisearch.js since this repo seemed a bit inactive. I would really love it if you could push this PR to invisearch.js, and help me keep this awesome library updated. /src files haven't changed in the new project. Thanks

@sheffieldnikki
Copy link
Contributor Author

Hi @sheffieldnick , I have forked this library and started a new project under the name of invisearch.js since this repo seemed a bit inactive.

Surely better to talk to @javve with an offer to help maintain this project instead of just copying it and giving it a new name?

@SanmayJoshi
Copy link

SanmayJoshi commented Apr 4, 2020

Surely better to talk to @javve with an offer to help maintain this project instead of just copying it and giving it a new name?

No doubt. Guess I was a bit too afraid to see this awesome library to be inactive. Am really looking forward for this library. What do you think @sheffieldnick should I do with the repo I have created? Deleting it seems proper.

Edit: Deleted.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@dfc930e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #683   +/-   ##
=========================================
  Coverage          ?   93.88%           
=========================================
  Files             ?       19           
  Lines             ?      818           
  Branches          ?      195           
=========================================
  Hits              ?      768           
  Misses            ?       34           
  Partials          ?       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfc930e...071b1a7. Read the comment docs.

@javve
Copy link
Owner

javve commented Nov 21, 2020

Hey @sheffieldnick, thanks a lot for your PRs and I'm so sorry for not reviewing them until now 😞
I made a big update today. I updated all development dependencies and ran all code via Prettier, which feels great.

However, that also created a bunch of conflicts in your PRs. I'm not really sure why there is so many conflicts or why there is a bunch of random commits included. But I guess it would sort itself our if you could make it so that your PRs was up to date with the new master.

Could you do that? That would be fantastic!

@sheffieldnikki
Copy link
Contributor Author

Could you do that? That would be fantastic!

No, but you've got all my code that had no conflicts at the time, so you are very welcome to do it yourself.

@javve javve changed the base branch from master to develop November 23, 2020 10:50
@javve javve changed the base branch from develop to pr-merger-for-sheffieldnick November 23, 2020 11:06
@javve
Copy link
Owner

javve commented Nov 23, 2020

That sounds reasonable @sheffieldnick 😅 Sorry for even asking you after all this time. I made it myself and put the fixes in this PR #696

Super nice work! I really appreciate it even though I haven't worked with List.js for a few years now, I feel really bad for you and other people who've made PRs during this time.

However, I hope to spend more time with this lib from now on!

@javve javve closed this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants