[NVIDIA] Reduce number of tests for jax.nn.dot_product_attention
#23223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbodenstein Can you take a look? |
kaixih
force-pushed
the
reduce_attn_tests
branch
2 times, most recently
from
dee1242
to
dd2ca19
Compare
superbobry
approved these changes
Aug 28, 2024
tests/nn_test.py
Outdated
| def _get_causal_mask(T, S): | ||
| causal_mask = jnp.tril(jnp.ones((T, S), dtype=jnp.bool_)) | ||
| return causal_mask[jnp.newaxis, jnp.newaxis, :, :] | ||
| def _check_cudnn_backend(fn, *args, **kwargs): |
There was a problem hiding this comment.
How about uses_cudnn_backend to reflect that this is a predicate and it will not raise if the condition is not met?
google-ml-butler
bot
added
kokoro:force-run
pull ready
kaixih
force-pushed
the
reduce_attn_tests
branch
from
dd2ca19
to
83fc48f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding the new mask mode,
sliding_window, I noticed that the number of tests has become quite large. Currently, every time we introduce a new option, it requires testing all possible combinations with existing options, which makes the number of tests increase exponentially. For example, we already have 864 parameterized tests for this API. This PR aims to address this issue by reducing the number of tests through grouping.For the new tests, we categorize them as follows:
vmap, groups, etc.Additionally, we will no longer maintain separate tests for inference and training.