Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise ValueError when axis1==axis2 for jnp.trace #23921

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Raise ValueError when axis1==axis2 for jnp.trace #23921

merged 1 commit into from
Sep 26, 2024

Conversation

rajasekharporeddy
Copy link
Contributor

No description provided.

@jakevdp jakevdp self-assigned this Sep 25, 2024
jakevdp
jakevdp reviewed Sep 26, 2024
View reviewed changes
tests/lax_numpy_test.py Outdated Show resolved Hide resolved
jakevdp
jakevdp reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can you please squash the changes into a single commit?

@rajasekharporeddy
Copy link
Contributor Author

Thanks! Squashed into single commit.

jakevdp
jakevdp approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Sep 26, 2024
@copybara-service copybara-service bot merged commit 96cf2b8 into jax-ml:main Sep 26, 2024
11 of 12 checks passed
@rajasekharporeddy rajasekharporeddy deleted the testbranch4 branch September 26, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakevdp jakevdp jakevdp approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajasekharporeddy @jakevdp