Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-character emoji support (Sourcery refactored) #3

Closed
wants to merge 2 commits into from

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Jul 16, 2021

Pull Request #2 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/jay3332/pilmoji pull/2/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

hex_code = format(ord(unicode[0]), 'x')
hex_code = '-'.join(format(ord(ch), 'x') for ch in unicode)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function AsyncRequester.get_twemoji refactored with the following changes:

hex_code = format(ord(unicode[0]), 'x')
hex_code = '-'.join(format(ord(ch), 'x') for ch in unicode)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function Requester.get_twemoji refactored with the following changes:

@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Jul 16, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.76%.

Quality metrics Before After Change
Complexity 0.84 ⭐ 0.84 ⭐ 0.00
Method Length 23.14 ⭐ 24.43 ⭐ 1.29 👎
Working memory 5.14 ⭐ 5.80 ⭐ 0.66 👎
Quality 88.79% 87.03% -1.76% 👎
Other metrics Before After Change
Lines 98 98 0
Changed files Quality Before Quality After Quality Change
pilmoji/aio/http.py 88.39% ⭐ 86.67% ⭐ -1.72% 👎
pilmoji/sync/http.py 89.20% ⭐ 87.41% ⭐ -1.79% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pilmoji/aio/http.py AsyncRequester.get_twemoji 2 ⭐ 70 🙂 10 😞 71.36% 🙂 Extract out complex expressions
pilmoji/sync/http.py Requester.get_twemoji 2 ⭐ 69 🙂 10 😞 71.51% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@jay3332 jay3332 closed this Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant