Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create and update github commands #264 #291

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

mrrsm
Copy link
Contributor

@mrrsm mrrsm commented Jul 15, 2020

  • Change get_file_contents to get_contents
  • Remove beginning '/' on paths

	- Change get_file_contents to get_contents
	- Remove beginning '/' on paths
@codecov-commenter
Copy link

Codecov Report

Merging #291 into master will increase coverage by 0.06%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   81.15%   81.21%   +0.06%     
==========================================
  Files           2        2              
  Lines         313      314       +1     
==========================================
+ Hits          254      255       +1     
  Misses         59       59              
Impacted Files Coverage Δ
statuspage/statuspage.py 72.42% <50.00%> (ø)
statuspage/tests.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dfcffc...3535d32. Read the comment docs.

@chenrui333
Copy link
Collaborator

@mrrsm can you rebase your PR to the latest master?

@mrrsm
Copy link
Contributor Author

mrrsm commented Feb 23, 2022

@chenrui333 I fixed the conflict but I have not tested anything.

If things are getting merged again I added maintenance blocks and did some default config tweaking (looking at my local commits) and would be happy to PR them.

@chenrui333 chenrui333 changed the title Fix create and update github commands #264 fix: create and update github commands #264 Feb 23, 2022
@chenrui333 chenrui333 merged commit 14ba352 into jayfk:master Feb 23, 2022
@chenrui333
Copy link
Collaborator

@mrrsm feel free to file a new PR, I am gonna need the latest master to test out something. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants