This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
feat(dockerfile): set ubuntu 20.04 and nodejs 14.x to be installed #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1012
💛 - Coveralls |
|
Noting that I have deleted notaorg / nota-ubuntu-16.04 on DockerHub. Related to #268. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows the Dockerfile used for Nota to use Ubuntu 20.04 and Node v14.x.
Any additional context?
Upgrading Ubuntu and Node allows us to continue receiving upstream updates that includes new features and bug fixes. This was made easier by having #249 merged.
The
.github/workflows/ubuntu-build.ymlwas deleted as it is no longer needed to do a daily build of ubuntu 16.04 for our database image and Nota. I will note to delete the associated docker repository on DockerHub after these changes has been merged toproduction.How were the changes in this PR tested if applicable?
The changes in this PR were tested locally by running
docker-compose up --exit-code-from nota.Any issues that are related to this PR?
This PR is related to issue #250