Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octicons v11.0.0 #6

Closed
jaynewey opened this issue Sep 11, 2020 · 1 comment Β· Fixed by #7
Closed

Octicons v11.0.0 #6

jaynewey opened this issue Sep 11, 2020 · 1 comment Β· Fixed by #7
Assignees

Comments

@jaynewey
Copy link
Owner

jaynewey commented Sep 11, 2020

Octicons recently received a major release: (v10.1.0 β†’ v11.0.0).

https://github.com/primer/octicons/releases/tag/v11.0.0

This release introduces some breaking changes:

πŸ’… Enhancements

  • Cache retrieval of Octicon SVG paths (#491)

πŸ’₯ Breaking changes

  • Fix 24px icon names #465 (@BenJetson πŸ™‡)
    • unverifed-24.svg β†’ unverified-24.svg
    • file-symlink-24.svg β†’ file-symlink-file-24.svg
    • fire-24.svg β†’ flame-24.svg
    • eye-slash-24.svg β†’ eye-closed-24.svg
  • Remove 24px settings icon. Use gear instead #493

As this repo/library is named django-octicons-v10 and updating to v11.0.0 would introduce breaking changes, there are two options at this point:

  • Keep this one as-is and create a new django-octicons-v11.
    Or:
  • Change this repo name to django-octicons-v11, keeping the django-octicons-v10 PyPi package, and making a new PyPi package under the new name.
@jaynewey jaynewey self-assigned this Sep 11, 2020
@jaynewey jaynewey pinned this issue Sep 28, 2020
@jaynewey
Copy link
Owner Author

jaynewey commented Oct 2, 2020

Okay, a third option I'm considering is:

  • Keeping the library name as django-octicons-v10
    • Pushing out the octicons v11.0.0 as a major release (2.0.0)

@jaynewey jaynewey mentioned this issue Oct 3, 2020
@jaynewey jaynewey unpinned this issue Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant