Cache Octicon SVGs for same icon/options combination #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR upstreams an optimization we've been using internally to speed up rendering the same octicon multiple times. Rendering octicons can be expensive when done often on a page. For example, rendering the same "check" octicon in a large list of items can add up on a page, so often we'll render it once and then pass in the rendered HTML string into the list items. Co-authored-by: Simon Taranto <srt32@github.com>
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/octicons/jmhxvol4m [update for 7a0eaf9 failed] |
jonrohan
approved these changes
Aug 28, 2020
| if octicons_helper_cache[cache_key] | ||
| octicons_helper_cache[cache_key] | ||
| else | ||
| icon = Octicons::Octicon.new(symbol, options) |
There was a problem hiding this comment.
Do you think we should include any of the raise conditions here when the symbol doesn't exist?
There was a problem hiding this comment.
@jonrohan Good idea! I think we should look into it in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upstreams an optimization we've been using
internally to speed up rendering the same octicon
multiple times.
Rendering octicons can be expensive when done often on a page. For
example, rendering the same "check" octicon in a large list of items can
add up on a page, so often we'll render it once and then pass in the
rendered HTML string into the list items.
Co-authored-by: Simon Taranto - @srt32