-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect order of downKeys #432
Comments
jaywcjlove
added a commit
that referenced
this issue
Jul 2, 2023
jaywcjlove
added a commit
that referenced
this issue
Jul 2, 2023
jaywcjlove
added a commit
that referenced
this issue
Jul 11, 2023
@YuxuanWeng Your fix has been reverted because it caused some problems with |
https://codesandbox.io/s/eager-pond-cstwrz?file=/src/App.tsx |
先摁的 重现问题 按住 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I discovered that when using
hotkeys('*', {keyup:true, keydown:true}, handler)
, with thekeyup
andkeydown
options set to true, if there are otherhotkeys('*', {}, handler2)
listeners present, the_downKeys
order gets rearranged. This causes an issue when I'm implementing keyboard shortcuts persistence because the order ofkeycodes
retrieved usinggetPressedKeyCodes
after keyup is incorrect.Here is the reproducible link: https://codesandbox.io/s/eager-pond-cstwrz?file=/src/App.tsx
The text was updated successfully, but these errors were encountered: