Add getAllKeyCodes method to API #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaywcjlove
added a commit
that referenced
this pull request
Aug 2, 2023
jaywcjlove
added a commit
that referenced
this pull request
Aug 2, 2023
|
@lokeshpathrabe Thanks a lot for your contribution. Modify the getAllKeyCodes method, compile and generate less code, and be compatible with older browsers |
jaywcjlove
added a commit
that referenced
this pull request
Aug 2, 2023
jaywcjlove
added a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new method to get list of all the registered codes from _handlers object. This was also raised in #223 way back. Though the workaround could work I think this could be pretty useful to display something like a map of hotkeys on a application.