fix positioning bug in Chrome #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* offset() returns { top: 0, left: 0 } when used with d3.
* getBoundingClientRect() can replace offset() and the following lines.
|
Excellent, just the fix needed. Thanks in 2018 :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this library with D3, and noticed that the tooltips position themselves in the upper left corner of the screen when using Chrome.
this.$element.offset()was returning{ top: 0, left: 0 }. I'm guessing this has to do with Webkit browsers and the way my D3 plots are rendered.This branch replaces the call to
$.extend({}, this.$element.offset(), {})withthis.$element[0].getBoundingClientRect(). This adds a few extra attributes to theposobject, but solves the issue and should work the same.