This repository has been archived by the owner on Jan 16, 2023. It is now read-only.
Use public APIs and update supported versions #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 29, 2017 21:38
* replace access to private method _normalize_name() of django-storages' S3Boto3Storage with storages.utils.safe_join() it is using - this allows using collectfast with other storages, e.g. django-minio-storage as well ;) * keep tox.ini in line with https://www.djangoproject.com/download/#supported-versions * keep .travis.yml in line with tox.ini * added .tox to .gitignore
|
Very cool, will review this as soon as find the time. I restarted the build for your last commit to see if Travis manages to pull 3.6. Cheers |
|
thx! |
antonagestam
reviewed
Jul 5, 2017
| @@ -2,3 +2,4 @@ | |||
| .coverage | |||
| .DS_Store | |||
| .coveragerc.swp | |||
| .tox | |||
There was a problem hiding this comment.
Please fix this newline error
antonagestam
reviewed
Jul 5, 2017
| @@ -50,7 +50,6 @@ def main(): | |||
| 'LOCATION': 'test-collectfast' | |||
| } | |||
| }, | |||
| "ROOT_URLCONF": app_name + ".urls", | |||
There was a problem hiding this comment.
Nvm, if tests pass without it it's all good :)
antonagestam
reviewed
Jul 5, 2017
| - TOXENV=py36-django111 | ||
| - TOXENV=pypy-django18 | ||
| - TOXENV=pypy-django110 | ||
| - TOXENV=pypy-django111 |
There was a problem hiding this comment.
I'm hesitant to adding pypy here. The build matrix is already quite large, but mainly because pypy is not officially supported by Django.
https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django
Merged
|
This is now published in the 0.6.0 release. Thank you again for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101 and enhances #99