Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12: sync module from CPython 3.10 #32

Merged

Conversation

ncoghlan
Copy link
Collaborator

  • Sync module and test suite from CPython 3.10
  • Switch test suite over to using unittest autodiscovery (since there are now two test files)
  • Capture the differences from the Python 3.10 version as a patch file
  • Ship the tox config (and other dev files) in the sdist

@ncoghlan ncoghlan requested a review from graingert June 26, 2021 08:04
@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #32 (032662d) into master (94f3881) will increase coverage by 2.99%.
The diff coverage is 95.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   92.34%   95.34%   +2.99%     
==========================================
  Files           1        1              
  Lines         196      365     +169     
  Branches       14       29      +15     
==========================================
+ Hits          181      348     +167     
- Misses         13       14       +1     
- Partials        2        3       +1     
Impacted Files Coverage Δ
contextlib2.py 95.34% <95.63%> (+2.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f3881...032662d. Read the comment docs.

Copy link
Member

@graingert graingert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also be good to pull in the typeshed contextlib.pyi file

@ncoghlan
Copy link
Collaborator Author

@graingert That's a good idea, but could you file a new ticket for it? IIRC, there's additional package metadata that has to be set to allow tools to find it properly.

@ncoghlan ncoghlan merged commit b99ed09 into jazzband:master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants