Update Clickmap id regular expression

jazzband · Apr 19, 2015 · e44141b · e44141b
1 parent 72b1716
commit e44141b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,3 +1,7 @@
+Development
+-----------
+* Fix Clickmap tracker id regular expression
+
 Version 0.21.0
 --------------
 * Added compatibility with Python 3 (Eric Amador)

diff --git a/analytical/templatetags/clickmap.py b/analytical/templatetags/clickmap.py
@@ -11,7 +11,7 @@
 from analytical.utils import is_internal_ip, disable_html, get_required_setting
 
 
-CLICKMAP_TRACKER_ID_RE = re.compile(r'^\d+$')
+CLICKMAP_TRACKER_ID_RE = re.compile(r'^\w+$')
 TRACKING_CODE = """
     <script type="text/javascript">
     var clickmapConfig = {tracker: '%(tracker_id)s', version:'2'};
@@ -47,7 +47,7 @@ class ClickmapNode(Node):
     def __init__(self):
         self.tracker_id = get_required_setting('CLICKMAP_TRACKER_ID',
                                                CLICKMAP_TRACKER_ID_RE,
-                                               "must be a (string containing) a number")
+                                               "must be an alphanumeric string")
 
     def render(self, context):
         html = TRACKING_CODE % {'tracker_id': self.tracker_id}

diff --git a/analytical/tests/test_tag_clickmap.py b/analytical/tests/test_tag_clickmap.py
@@ -11,25 +11,25 @@
 from analytical.utils import AnalyticalException
 
 
-@override_settings(CLICKMAP_TRACKER_ID='12345')
+@override_settings(CLICKMAP_TRACKER_ID='12345ABC')
 class ClickmapTagTestCase(TagTestCase):
     """
     Tests for the ``clickmap`` template tag.
     """
 
     def test_tag(self):
         r = self.render_tag('clickmap', 'clickmap')
-        self.assertTrue("tracker: '12345', version:'2'};" in r, r)
+        self.assertTrue("tracker: '12345ABC', version:'2'};" in r, r)
 
     def test_node(self):
         r = ClickmapNode().render(Context({}))
-        self.assertTrue("tracker: '12345', version:'2'};" in r, r)
+        self.assertTrue("tracker: '12345ABC', version:'2'};" in r, r)
 
     @override_settings(CLICKMAP_TRACKER_ID=None)
     def test_no_site_id(self):
         self.assertRaises(AnalyticalException, ClickmapNode)
 
-    @override_settings(CLICKMAP_TRACKER_ID='abc')
+    @override_settings(CLICKMAP_TRACKER_ID='ab#c')
     def test_wrong_site_id(self):
         self.assertRaises(AnalyticalException, ClickmapNode)