Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm Python 3.12 support #572

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

jgillard
Copy link
Contributor

@jgillard jgillard commented Oct 3, 2023

I followed the pattern set by the previous 3.11 MR: #447

The tox envlist change might be debatable, but my understanding is that Python 3.12 will only be supported on 4.2 and above.

As my colleague mentioned in #570, we've just started using v3 of this package, so happy to chip in with small things like this. I thought it might want adding for 3.0. We know that we shouldn't be using v3 yet, but the risk level is fine for what we're doing.

Thanks for your efforts!

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #572 (359af4c) into master (e15a610) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #572   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files          31       31           
  Lines        1004     1004           
=======================================
  Hits          954      954           
  Misses         50       50           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hramezani
Copy link
Member

hramezani commented Oct 5, 2023

Thanks @jgillard for this patch 🙏

Based on Django supported Python versions, Django not support Python 3.12.
Django 5.0 supports Python 3.12 and will be released in December 2023.

So, let's keep 3.12 only for main branch for now.

@jgillard
Copy link
Contributor Author

jgillard commented Oct 5, 2023

You're correct about Django 4.2 not supporting Python 3.12 (although that may change at some point), so for now I've only applied it to django's main branch as you suggested.

@hramezani hramezani merged commit a034588 into jazzband:master Nov 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants