Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Django 4.1, 4.2 and Python 3.11 #485

Merged
merged 12 commits into from
Jan 13, 2024

Conversation

johnthagen
Copy link
Contributor

@johnthagen johnthagen commented May 25, 2023

CI

Closes #486

Description

@johnthagen johnthagen removed the request for review from Archmonger May 25, 2023 19:59
@johnthagen johnthagen marked this pull request as draft May 25, 2023 19:59
@johnthagen

This comment was marked as outdated.

@johnthagen johnthagen changed the title Support Django 4.1 and 4.2 and Python 3.11 Support Django 4.1 and Python 3.11 May 27, 2023
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (790ec8b) 91.12% compared to head (3b2ba60) 91.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #485   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files          19       19           
  Lines         856      856           
  Branches      144      150    +6     
=======================================
  Hits          780      780           
  Misses         41       41           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnthagen johnthagen marked this pull request as ready for review May 27, 2023 19:50
@johnthagen
Copy link
Contributor Author

@Archmonger If you could review that would be great. The project settings will need to be updated so that Python 3.7 is no longer required, and Python 3.11 is set to be required.

@johnthagen johnthagen self-assigned this May 27, 2023
@Archmonger
Copy link
Contributor

Archmonger commented May 27, 2023

Will review soon, but unfortunately I cannot change the GitHub test requirements.

We'll have to wait until Janis transfers us out of Jazzband.

Copy link
Contributor

@Archmonger Archmonger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unfortunately can't merge until the jazzband situation gets addressed.

requirements/tests.txt Show resolved Hide resolved
@johnthagen johnthagen changed the title Support Django 4.1 and Python 3.11 Support Django 4.1, 4.2 and Python 3.11 May 31, 2023
@johnthagen johnthagen mentioned this pull request May 31, 2023
@johnthagen johnthagen merged commit 8f32a28 into jazzband:master Jan 13, 2024
8 checks passed
@johnthagen johnthagen deleted the django-4.1,4.2-py-3.11 branch January 13, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Django 4.2
2 participants