Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the way Attribute.slug field is generated #227

Merged
merged 11 commits into from
Aug 12, 2022

Conversation

Dresdn
Copy link
Contributor

@Dresdn Dresdn commented Aug 12, 2022

I'm helping!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issue(s)

Closes #223

Other Information

@Dresdn Dresdn changed the title Dresdn/issue 223 Update the way Attribute.slug field is generated Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #227 (bbf12d5) into master (850ee17) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   89.79%   89.98%   +0.18%     
==========================================
  Files          20       22       +2     
  Lines         745      759      +14     
  Branches      134      135       +1     
==========================================
+ Hits          669      683      +14     
  Misses         52       52              
  Partials       24       24              
Impacted Files Coverage Δ
eav/fields.py 71.42% <ø> (-5.63%) ⬇️
eav/migrations/0001_initial.py 100.00% <ø> (ø)
eav/logic/slug.py 100.00% <100.00%> (ø)
eav/migrations/0008_use_native_slugfield.py 100.00% <100.00%> (ø)
eav/models.py 97.28% <100.00%> (+0.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dresdn Dresdn merged commit 8a7d16d into jazzband:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute slug length is limited to 50 chars
1 participant