Fix BaseEntityAdmin #239
Merged
Fix BaseEntityAdmin #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikalai-hryb
commented
Aug 31, 2022
Comment on lines
+11
to
+12
| - Fixes missing `Add another` button for inlines in `BaseEntityAdmin` | ||
|
|
There was a problem hiding this comment.
before fix
after fix
mikalai-hryb
commented
Aug 31, 2022
|
|
||
| # Infer correct data from the form. | ||
| fieldsets = self.fieldsets or [(None, {'fields': form.fields.keys()})] | ||
| adminform = admin.helpers.AdminForm(form, fieldsets, self.prepopulated_fields) | ||
| media = mark_safe(self.media + adminform.media) | ||
| media = mark_safe(media + adminform.media) |
There was a problem hiding this comment.
I am using Django 3.2
When I created class ProductAdmin(BaseEntityAdmin) the Add another button for inline fields disappeared.
This happens because the self.media returns this and there is no admin/js/inlines.js there by default.
The Add another button for inlines is added on the fly by admin/js/inlines.js script.
The context["media"] contains current/nessasary form assets to create the button.
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 89.98% 90.00% +0.01%
==========================================
Files 22 22
Lines 759 760 +1
Branches 135 135
==========================================
+ Hits 683 684 +1
Misses 52 52
Partials 24 24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm helping!
Checklist
CHANGELOG.mdPull Request type
Please check the type of change your PR introduces:
Related issue(s)
Other Information