-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request object missing from Django authentication #636
Comments
IvanAnishchuk
pushed a commit
that referenced
this issue
Oct 20, 2019
Fixed in #643 I believe. |
ShaheedHaque
added a commit
to ShaheedHaque/django-oauth-toolkit
that referenced
this issue
Mar 22, 2021
compatibiity with more backends. Resolves jazzband#712. Resolves jazzband#636. Resolves jazzband#808.
Merged
5 tasks
ShaheedHaque
added a commit
to ShaheedHaque/django-oauth-toolkit
that referenced
this issue
Mar 22, 2021
compatibiity with more backends. Resolves jazzband#712. Resolves jazzband#636. Resolves jazzband#808.
ShaheedHaque
added a commit
to ShaheedHaque/django-oauth-toolkit
that referenced
this issue
Mar 22, 2021
compatibiity with more backends. Resolves jazzband#712. Resolves jazzband#636. Resolves jazzband#808.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
First of all, thanks for creating this toolkit and hope this request will expand it's usage.
Many third party AUTHENTICATION_BACKENDS requires request object. This toolkit is not passing request object to django.contrib.auth.authenticate(). If you will update oauth2_validators.py=>validate_user's authenticate call from authenticate(username=username, password=password) to authenticate(request=request, username=username, password=password) will fix this issue.
Hope you will be able to make this change quickly.
Thanks with best regards,
ripal-pm
The text was updated successfully, but these errors were encountered: